[Asterisk-code-review] main/pbx.c: Fixed to call the ast_softhangup() (...asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11149 )

Change subject: main/pbx.c: Fixed to call the ast_softhangup()
......................................................................


Patch Set 8:

(1 comment)

> Patch Set 7:
> 
> (1 comment)

Thank you for replying. :) I've replied it.

https://gerrit.asterisk.org/#/c/11149/6/res/ari/resource_channels.c 
File res/ari/resource_channels.c:

https://gerrit.asterisk.org/#/c/11149/6/res/ari/resource_channels.c@1000 
PS6, Line 1000: 			ret = pbx_exec(ast_dial_answered(dial), app, origination->appdata);
> I meant why is this change necessary now? Is it because before the channel remained valid and so the […]
Ah, now I've got it.
Yes. As you explain, I thought the hangup should be done in the pbx_exec() for the normal case. 

Hm.. I think this should check the return value of pbx_exec(). If the return value is not normal this function should handle the hangup.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11149
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I6652359e42bb9fe3f2c44c03df4365c183baf73d
Gerrit-Change-Number: 11149
Gerrit-PatchSet: 8
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Tue, 02 Apr 2019 23:56:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: sungtae kim <pchero21 at gmail.com>
Comment-In-Reply-To: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190402/3625e4ab/attachment-0001.html>