[Asterisk-code-review] main/pbx.c: Fixed to call the ast_softhangup() (...asterisk[master])

sungtae kim asteriskteam at digium.com
Mon Apr 8 16:35:58 CDT 2019


sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11149 )

Change subject: main/pbx.c: Fixed to call the ast_softhangup()
......................................................................


Patch Set 8:

(1 comment)

Replied.

https://gerrit.asterisk.org/#/c/11149/8/res/ari/resource_channels.c 
File res/ari/resource_channels.c:

https://gerrit.asterisk.org/#/c/11149/8/res/ari/resource_channels.c@1683 
PS8, Line 1683: 		/* channel is already hungup. */
> This needs to go into more detail, and also be above the other pbx_exec. […]
Hi Joshua,

Thank you for your kind review.

Yes, if the channel continued from the stasis(), the Asterisk doesn't send the ChannelHangupRequest ARI/AMI events.

It just send a Hangup/ChannelDestroyed event.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11149
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I6652359e42bb9fe3f2c44c03df4365c183baf73d
Gerrit-Change-Number: 11149
Gerrit-PatchSet: 8
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Mon, 08 Apr 2019 21:35:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190408/7ca4a0d8/attachment.html>


More information about the asterisk-code-review mailing list