[Asterisk-code-review] loader: support for permanent dlopen() (...asterisk[master])

[Sebastian Kemper]

Sebastian Kemper has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11217 )

Change subject: loader: support for permanent dlopen()
......................................................................


Patch Set 2: -Code-Review

> Patch Set 2: Code-Review-1
> 
> A couple more issues I noticed.  In addition please make sure you use `./configure --enable-dev-mode --enable-permanent-dlopen` for testing.  This configures the compiler to be more aggressive about what will cause a compile error.

Hello Corey,

Thanks again! I've updated the two snippets as requested.

Then I compiled with --enable-dev-mode. There were still no warnings/errors during the loader compile:

ccache_cc -o loader.o -c loader.c -MD -MT loader.o -MF .loader.o.d -MP -pthread -I/home/sk/tmp/openwrt/build_dir/target-mips_24kc_musl/asterisk-16.2.1/include -ggdb3 -pipe -mno-branch-likely -mips32r2 -mtune=24kc -fno-caller-saves -fno-plt -fhonour-copts -Wno-error=unused-but-set-variable -Wno-error=unused-result -msoft-float -mips16 -minterlink-mips16 -iremap/home/sk/tmp/openwrt/build_dir/target-mips_24kc_musl/asterisk-16.2.1:asterisk-16.2.1 -Wformat -Werror=format-security -fstack-protector -D_FORTIFY_SOURCE=1 -Wl,-z,now -Wl,-z,relro -I/home/sk/tmp/openwrt/staging_dir/target-mips_24kc_musl/usr/lib/libiconv-stub/include -I/home/sk/tmp/openwrt/staging_dir/target-mips_24kc_musl/usr/lib/libintl-stub/include    -I/home/sk/tmp/openwrt/staging_dir/target-mips_24kc_musl/usr/include/libxml2  -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations    -Werror -Wunused -Wdeclaration-after-statement -Wtrampolines -Wundef -Wmissing-format-attribute -Wformat=2  -O0 -DAST_MODULE=\"core\" -DAST_IN_CORE

The compile died later:

ccache_cc -o res_pjproject.o -c res_pjproject.c -MD -MT res_pjproject.o -MF .res_pjproject.o.d -MP -pthread -I/home/sk/tmp/openwrt/build_dir/target-mips_24kc_musl/asterisk-16.2.1/include -ggdb3 -pipe -mno-branch-likely -mips32r2 -mtune=24kc -fno-caller-saves -fno-plt -fhonour-copts -Wno-error=unused-but-set-variable -Wno-error=unused-result -msoft-float -mips16 -minterlink-mips16 -iremap/home/sk/tmp/openwrt/build_dir/target-mips_24kc_musl/asterisk-16.2.1:asterisk-16.2.1 -Wformat -Werror=format-security -fstack-protector -D_FORTIFY_SOURCE=1 -Wl,-z,now -Wl,-z,relro -I/home/sk/tmp/openwrt/staging_dir/target-mips_24kc_musl/usr/lib/libiconv-stub/include -I/home/sk/tmp/openwrt/staging_dir/target-mips_24kc_musl/usr/lib/libintl-stub/include    -I/home/sk/tmp/openwrt/staging_dir/target-mips_24kc_musl/usr/include/libxml2  -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations    -Werror -Wunused -Wdeclaration-after-statement -Wtrampolines -Wundef -Wmissing-format-attribute -Wformat=2  -O0 -fPIC -DAST_MODULE=\"res_pjproject\" -DAST_MODULE_SELF_SYM=__internal_res_pjproject_self  -DPJ_AUTOCONF=1 -DPJ_IS_BIG_ENDIAN=1 -DPJ_IS_LITTLE_ENDIAN=0 -fPIC -I/home/sk/tmp/openwrt/staging_dir/target-mips_24kc_musl/usr/include  
res_pjproject.c: In function 'get_log_level':
res_pjproject.c:180:12: error: implicit declaration of function 'fmin' [-Werror=implicit-function-declaration]
  l = '0' + fmin(pj_level, 9);
            ^~~~
res_pjproject.c:180:12: error: incompatible implicit declaration of built-in function 'fmin' [-Werror]
res_pjproject.c:180:12: note: include '<math.h>' or provide a declaration of 'fmin'
cc1: all warnings being treated as errors

But this is unrelated to the loader, so I'll just disregard it.

I'll start run-testing now and ping you back after.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11217
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I86693a0ecf25d5ba81c73773a03df4abc3426875
Gerrit-Change-Number: 11217
Gerrit-PatchSet: 2
Gerrit-Owner: Sebastian Kemper <sebastian_ml at gmx.net>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sebastian Kemper <sebastian_ml at gmx.net>
Gerrit-Comment-Date: Thu, 04 Apr 2019 17:57:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190404/97b19175/attachment.html>