<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 2: Code-Review-1</p><p style="white-space: pre-wrap; word-wrap: break-word;">A couple more issues I noticed. In addition please make sure you use `./configure --enable-dev-mode --enable-permanent-dlopen` for testing. This configures the compiler to be more aggressive about what will cause a compile error.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Hello Corey,</p><p style="white-space: pre-wrap; word-wrap: break-word;">Thanks again! I've updated the two snippets as requested.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Then I compiled with --enable-dev-mode. There were still no warnings/errors during the loader compile:</p><p style="white-space: pre-wrap; word-wrap: break-word;">ccache_cc -o loader.o -c loader.c -MD -MT loader.o -MF .loader.o.d -MP -pthread -I/home/sk/tmp/openwrt/build_dir/target-mips_24kc_musl/asterisk-16.2.1/include -ggdb3 -pipe -mno-branch-likely -mips32r2 -mtune=24kc -fno-caller-saves -fno-plt -fhonour-copts -Wno-error=unused-but-set-variable -Wno-error=unused-result -msoft-float -mips16 -minterlink-mips16 -iremap/home/sk/tmp/openwrt/build_dir/target-mips_24kc_musl/asterisk-16.2.1:asterisk-16.2.1 -Wformat -Werror=format-security -fstack-protector -D_FORTIFY_SOURCE=1 -Wl,-z,now -Wl,-z,relro -I/home/sk/tmp/openwrt/staging_dir/target-mips_24kc_musl/usr/lib/libiconv-stub/include -I/home/sk/tmp/openwrt/staging_dir/target-mips_24kc_musl/usr/lib/libintl-stub/include -I/home/sk/tmp/openwrt/staging_dir/target-mips_24kc_musl/usr/include/libxml2 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Werror -Wunused -Wdeclaration-after-statement -Wtrampolines -Wundef -Wmissing-format-attribute -Wformat=2 -O0 -DAST_MODULE=\"core\" -DAST_IN_CORE</p><p style="white-space: pre-wrap; word-wrap: break-word;">The compile died later:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ccache_cc -o res_pjproject.o -c res_pjproject.c -MD -MT res_pjproject.o -MF .res_pjproject.o.d -MP -pthread -I/home/sk/tmp/openwrt/build_dir/target-mips_24kc_musl/asterisk-16.2.1/include -ggdb3 -pipe -mno-branch-likely -mips32r2 -mtune=24kc -fno-caller-saves -fno-plt -fhonour-copts -Wno-error=unused-but-set-variable -Wno-error=unused-result -msoft-float -mips16 -minterlink-mips16 -iremap/home/sk/tmp/openwrt/build_dir/target-mips_24kc_musl/asterisk-16.2.1:asterisk-16.2.1 -Wformat -Werror=format-security -fstack-protector -D_FORTIFY_SOURCE=1 -Wl,-z,now -Wl,-z,relro -I/home/sk/tmp/openwrt/staging_dir/target-mips_24kc_musl/usr/lib/libiconv-stub/include -I/home/sk/tmp/openwrt/staging_dir/target-mips_24kc_musl/usr/lib/libintl-stub/include -I/home/sk/tmp/openwrt/staging_dir/target-mips_24kc_musl/usr/include/libxml2 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Werror -Wunused -Wdeclaration-after-statement -Wtrampolines -Wundef -Wmissing-format-attribute -Wformat=2 -O0 -fPIC -DAST_MODULE=\"res_pjproject\" -DAST_MODULE_SELF_SYM=__internal_res_pjproject_self -DPJ_AUTOCONF=1 -DPJ_IS_BIG_ENDIAN=1 -DPJ_IS_LITTLE_ENDIAN=0 -fPIC -I/home/sk/tmp/openwrt/staging_dir/target-mips_24kc_musl/usr/include <br>res_pjproject.c: In function 'get_log_level':<br>res_pjproject.c:180:12: error: implicit declaration of function 'fmin' [-Werror=implicit-function-declaration]<br> l = '0' + fmin(pj_level, 9);<br> ^~~~<br>res_pjproject.c:180:12: error: incompatible implicit declaration of built-in function 'fmin' [-Werror]<br>res_pjproject.c:180:12: note: include '<math.h>' or provide a declaration of 'fmin'<br>cc1: all warnings being treated as errors</pre><p style="white-space: pre-wrap; word-wrap: break-word;">But this is unrelated to the loader, so I'll just disregard it.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I'll start run-testing now and ping you back after.</p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ddd; color: #000000;">-Code-Review</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11217">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11217">change 11217</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11217"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I86693a0ecf25d5ba81c73773a03df4abc3426875 </div>
<div style="display:none"> Gerrit-Change-Number: 11217 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Sebastian Kemper <sebastian_ml@gmx.net> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Sebastian Kemper <sebastian_ml@gmx.net> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 04 Apr 2019 17:57:38 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>