[Asterisk-code-review] loader: support for permanent dlopen() (...asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11217 )

Change subject: loader: support for permanent dlopen()
......................................................................


Patch Set 2:

> A couple more issues I noticed.  In addition please make sure you
 > use `./configure --enable-dev-mode --enable-permanent-dlopen` for
 > testing.  This configures the compiler to be more aggressive about
 > what will cause a compile error.

I should say this is especially important for your change since jenkins does not enable permanent-dlopen, so it's not even verifying that your code can be compiled.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11217
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I86693a0ecf25d5ba81c73773a03df4abc3426875
Gerrit-Change-Number: 11217
Gerrit-PatchSet: 2
Gerrit-Owner: Sebastian Kemper <sebastian_ml at gmx.net>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sebastian Kemper <sebastian_ml at gmx.net>
Gerrit-Comment-Date: Wed, 03 Apr 2019 21:55:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190403/20da3d12/attachment-0001.html>