[Asterisk-code-review] main/pbx.c: Fixed to call the ast_softhangup() (...asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11149 )

Change subject: main/pbx.c: Fixed to call the ast_softhangup()
......................................................................


Patch Set 7:

(2 comments)

> Patch Set 6: Code-Review-1
> 
> (2 comments)

Hi Joshua,

Fixed it as your comment. :)

Btw, I'm not clear what you asking at Line 1000. Replied it anyways, but feel free to ask again if it's not the answer.

https://gerrit.asterisk.org/#/c/11149/6/res/ari/resource_channels.c 
File res/ari/resource_channels.c:

https://gerrit.asterisk.org/#/c/11149/6/res/ari/resource_channels.c@1000 
PS6, Line 1000: 			ret = pbx_exec(ast_dial_answered(dial), app, origination->appdata);
> Can you explain what happened before in this section? […]
Hm. I'm not sure what you asking about.

This is actual ARI's channel dialing handler. In this function, it makes an actual call, and firing the PBX looping.

Agree, it can be substituted.


https://gerrit.asterisk.org/#/c/11149/6/res/ari/resource_channels.c@1682 
PS6, Line 1682: 	if (ret != -1) {
> Add a comment why this is done
Np, added it.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11149
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I6652359e42bb9fe3f2c44c03df4365c183baf73d
Gerrit-Change-Number: 11149
Gerrit-PatchSet: 7
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Tue, 02 Apr 2019 23:10:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190402/94edb534/attachment.html>