<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 6: Code-Review-1</p><p style="white-space: pre-wrap; word-wrap: break-word;">(2 comments)</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Hi Joshua,</p><p style="white-space: pre-wrap; word-wrap: break-word;">Fixed it as your comment. :)</p><p style="white-space: pre-wrap; word-wrap: break-word;">Btw, I'm not clear what you asking at Line 1000. Replied it anyways, but feel free to ask again if it's not the answer.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11149">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11149/6/res/ari/resource_channels.c">File res/ari/resource_channels.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11149/6/res/ari/resource_channels.c@1000">Patch Set #6, Line 1000:</a> <code style="font-family:monospace,monospace">                        ret = pbx_exec(ast_dial_answered(dial), app, origination->appdata);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Can you explain what happened before in this section? […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Hm. I'm not sure what you asking about.</p><p style="white-space: pre-wrap; word-wrap: break-word;">This is actual ARI's channel dialing handler. In this function, it makes an actual call, and firing the PBX looping.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Agree, it can be substituted.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11149/6/res/ari/resource_channels.c@1682">Patch Set #6, Line 1682:</a> <code style="font-family:monospace,monospace">     if (ret != -1) {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Add a comment why this is done</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Np, added it.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11149">change 11149</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11149"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6652359e42bb9fe3f2c44c03df4365c183baf73d </div>
<div style="display:none"> Gerrit-Change-Number: 11149 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 02 Apr 2019 23:10:48 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>