[Asterisk-code-review] configure.ac: Check for unbound version >= 1.5 (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10268 )

Change subject: configure.ac:  Check for unbound version >= 1.5
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/10268/1/autoconf/ast_ext_lib.m4
File autoconf/ast_ext_lib.m4:

https://gerrit.asterisk.org/#/c/10268/1/autoconf/ast_ext_lib.m4@263
PS1, Line 263:       AC_RUN_IFELSE(
Do you have any plans that will require AC_RUN_IFELSE?  The check you are doing for libunbound only requires AC_COMPILE_IFELSE or AC_LINK_IFELSE.  My complaint about AC_RUN_IFELSE is that it doesn't work for cross-compile so we should avoid it wherever possible.

If you keep AC_RUN_IFELSE then you need to add the `action-if-cross-compiling` argument:
[
$1_VALIDATED="1"
AC_MSG_RESULT([yes (guessed for cross-compile)])
]


https://www.gnu.org/software/autoconf//manual/autoconf-2.69/autoconf.html#index-AC_005fRUN_005fIFELSE-1185


https://gerrit.asterisk.org/#/c/10268/1/menuselect/configure
File menuselect/configure:

https://gerrit.asterisk.org/#/c/10268/1/menuselect/configure@a1029
PS1, Line 1029: 
Nothing to do with this review but I want to bring this up while I think of it.  In the future when someone submits a review with a configure script change that re-adds '--runstatedir' we should have someone else run ./bootstrap.sh from a current distro to update that review / prevent runstatedir from ever being added to configure / menuselect/configure.  My understanding is that runstatedir is from older versions of autoconf



-- 
To view, visit https://gerrit.asterisk.org/10268
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee94ad543cd6f8b118df8c4c7afd9c4e2ca1fa72
Gerrit-Change-Number: 10268
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Comment-Date: Tue, 25 Sep 2018 17:13:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180925/172648b0/attachment.html>