<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/10268">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10268/1/autoconf/ast_ext_lib.m4">File autoconf/ast_ext_lib.m4:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10268/1/autoconf/ast_ext_lib.m4@263">Patch Set #1, Line 263:</a> <code style="font-family:monospace,monospace">      AC_RUN_IFELSE(</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Do you have any plans that will require AC_RUN_IFELSE?  The check you are doing for libunbound only requires AC_COMPILE_IFELSE or AC_LINK_IFELSE.  My complaint about AC_RUN_IFELSE is that it doesn't work for cross-compile so we should avoid it wherever possible.</p><p style="white-space: pre-wrap; word-wrap: break-word;">If you keep AC_RUN_IFELSE then you need to add the `action-if-cross-compiling` argument:<br>[<br>$1_VALIDATED="1"<br>AC_MSG_RESULT([yes (guessed for cross-compile)])<br>]</p><p style="white-space: pre-wrap; word-wrap: break-word;"><br>https://www.gnu.org/software/autoconf//manual/autoconf-2.69/autoconf.html#index-AC_005fRUN_005fIFELSE-1185</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10268/1/menuselect/configure">File menuselect/configure:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10268/1/menuselect/configure@a1029">Patch Set #1, Line 1029:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Nothing to do with this review but I want to bring this up while I think of it.  In the future when someone submits a review with a configure script change that re-adds '--runstatedir' we should have someone else run ./bootstrap.sh from a current distro to update that review / prevent runstatedir from ever being added to configure / menuselect/configure.  My understanding is that runstatedir is from older versions of autoconf</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10268">change 10268</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10268"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Iee94ad543cd6f8b118df8c4c7afd9c4e2ca1fa72 </div>
<div style="display:none"> Gerrit-Change-Number: 10268 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 25 Sep 2018 17:13:27 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>