[Asterisk-code-review] configure.ac: Check for unbound version >= 1.5 (asterisk[master])

George Joseph asteriskteam at digium.com
Tue Sep 25 14:31:55 CDT 2018


Hello Jenkins2, Corey Farrell, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/10268

to look at the new patch set (#2).

Change subject: configure.ac:  Check for unbound version >= 1.5
......................................................................

configure.ac:  Check for unbound version >= 1.5

In order to do this and provide good feedback, a new macro was
created (AST_EXT_LIB_EXTRA_CHECK) which does the normal check and
path setups for the library then compiles, links and runs a supplied
code fragment to do the final determination.  In this case, the
final code fragment compares UNBOUND_VERSION_MAJOR
and UNBOUND_VERSION_MINOR to determine if they're greater than or
equal to 1.5.

Since we require version 1.5, some code in res_resolver_unbound
was also simplified.

ASTERISK-28045
Reported by: Samuel Galarneau

Change-Id: Iee94ad543cd6f8b118df8c4c7afd9c4e2ca1fa72
---
M autoconf/ast_ext_lib.m4
M configure
M configure.ac
M include/asterisk/autoconfig.h.in
M menuselect/configure
M res/res_resolver_unbound.c
6 files changed, 196 insertions(+), 124 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/68/10268/2
-- 
To view, visit https://gerrit.asterisk.org/10268
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iee94ad543cd6f8b118df8c4c7afd9c4e2ca1fa72
Gerrit-Change-Number: 10268
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180925/861cecef/attachment.html>


More information about the asterisk-code-review mailing list