[Asterisk-code-review] loader: Perform chained starts when missing dependencies are... (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10447 )

Change subject: loader: Perform chained starts when missing dependencies are started.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/10447/1/main/loader.c
File main/loader.c:

https://gerrit.asterisk.org/#/c/10447/1/main/loader.c@1679
PS1, Line 1679: int ast_load_resource(const char *resource_name)
> The return type does not match the prototype: […]
So that can be changed without breaking the ABI right?


https://gerrit.asterisk.org/#/c/10447/1/main/loader.c@2359
PS1, Line 2359: 				cur->flags.running ? "Running" : "Not Running", like, cur->info->support_level);
> Were you going to update the module status reported? […]
I can.  If these values are provided by ARI/AMI would that require bumping the protocol versions or noting CHANGES?



-- 
To view, visit https://gerrit.asterisk.org/10447
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cfe77a550a036b549ff5c47c05f69eead61f5e3
Gerrit-Change-Number: 10447
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 15 Oct 2018 23:14:00 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181015/000a38e4/attachment.html>