[Asterisk-code-review] loader: Perform chained starts when missing dependencies are... (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10447 )

Change subject: loader: Perform chained starts when missing dependencies are started.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/10447/1/main/loader.c
File main/loader.c:

https://gerrit.asterisk.org/#/c/10447/1/main/loader.c@1679
PS1, Line 1679: int ast_load_resource(const char *resource_name)
> So that can be changed without breaking the ABI right?
yes since an enum is integer based and we are returning the enum values already


https://gerrit.asterisk.org/#/c/10447/1/main/loader.c@2359
PS1, Line 2359: 				cur->flags.running ? "Running" : "Not Running", like, cur->info->support_level);
> I can. […]
This function is only called by CLI and SNMP as noted so there isn't anything else that would need doing.

As noted, the other two functions are called by ARI and the status string is placed in a json object.  Technically a revision bump would be necessary along with CHANGES for those.  However, I'm not sure what kind of the value it really is though.  Is it a display string or an enum value?  If it is a display string then nothing else would need to be done.  If it is an enum then it would need further documentation.

rest-api/api-docs/asterisk.json doesn't seem to list the status json object member.
GET asterisk/modules/ -- get information on all modules
GET asterisk/modules/{moduleName} -- get named module information



-- 
To view, visit https://gerrit.asterisk.org/10447
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cfe77a550a036b549ff5c47c05f69eead61f5e3
Gerrit-Change-Number: 10447
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 16 Oct 2018 00:59:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181015/ba2e52f0/attachment.html>