[Asterisk-code-review] loader: Perform chained starts when missing dependencies are... (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10447 )

Change subject: loader: Perform chained starts when missing dependencies are started.
......................................................................


Patch Set 1:

(4 comments)

Looks fine.  Just some questions.

https://gerrit.asterisk.org/#/c/10447/1/main/loader.c
File main/loader.c:

https://gerrit.asterisk.org/#/c/10447/1/main/loader.c@1679
PS1, Line 1679: int ast_load_resource(const char *resource_name)
The return type does not match the prototype:

enum ast_module_load_result ast_load_resource(const char *resource_name);


https://gerrit.asterisk.org/#/c/10447/1/main/loader.c@2359
PS1, Line 2359: 				cur->flags.running ? "Running" : "Not Running", like, cur->info->support_level);
Were you going to update the module status reported?

Running
Missing Dep
Declined

if (cur->flags.running) {
   status = "Running";
} else if (cur->flags.missingdep) {
   status = "Missing Dep";
} else {
   status = "Declined";
}

CLI calls this function.
SNMP calls this function but only cares about the returned count.


https://gerrit.asterisk.org/#/c/10447/1/main/loader.c@2387
PS1, Line 2387: 				cur->flags.running? "Running" : "Not Running", like, cur->info->support_level, data);
same

ARI calls this function


https://gerrit.asterisk.org/#/c/10447/1/main/loader.c@2416
PS1, Line 2416: 				cur->flags.running? "Running" : "Not Running", like, cur->info->support_level, data,
same

ARI calls this function



-- 
To view, visit https://gerrit.asterisk.org/10447
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cfe77a550a036b549ff5c47c05f69eead61f5e3
Gerrit-Change-Number: 10447
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 15 Oct 2018 23:03:56 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181015/53e1f713/attachment.html>