<p style="white-space: pre-wrap; word-wrap: break-word;">Looks fine.  Just some questions.</p><p><a href="https://gerrit.asterisk.org/10447">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10447/1/main/loader.c">File main/loader.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10447/1/main/loader.c@1679">Patch Set #1, Line 1679:</a> <code style="font-family:monospace,monospace">int ast_load_resource(const char *resource_name)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">The return type does not match the prototype:</p><p style="white-space: pre-wrap; word-wrap: break-word;">enum ast_module_load_result ast_load_resource(const char *resource_name);</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10447/1/main/loader.c@2359">Patch Set #1, Line 2359:</a> <code style="font-family:monospace,monospace">                           cur->flags.running ? "Running" : "Not Running", like, cur->info->support_level);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Were you going to update the module status reported?</p><p style="white-space: pre-wrap; word-wrap: break-word;">Running<br>Missing Dep<br>Declined</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">if (cur->flags.running) {<br>   status = "Running";<br>} else if (cur->flags.missingdep) {<br>   status = "Missing Dep";<br>} else {<br>   status = "Declined";<br>}</pre><p style="white-space: pre-wrap; word-wrap: break-word;">CLI calls this function.<br>SNMP calls this function but only cares about the returned count.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10447/1/main/loader.c@2387">Patch Set #1, Line 2387:</a> <code style="font-family:monospace,monospace">                            cur->flags.running? "Running" : "Not Running", like, cur->info->support_level, data);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">same</p><p style="white-space: pre-wrap; word-wrap: break-word;">ARI calls this function</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10447/1/main/loader.c@2416">Patch Set #1, Line 2416:</a> <code style="font-family:monospace,monospace">                          cur->flags.running? "Running" : "Not Running", like, cur->info->support_level, data,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">same</p><p style="white-space: pre-wrap; word-wrap: break-word;">ARI calls this function</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10447">change 10447</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10447"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I1cfe77a550a036b549ff5c47c05f69eead61f5e3 </div>
<div style="display:none"> Gerrit-Change-Number: 10447 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 15 Oct 2018 23:03:56 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>