[Asterisk-code-review] bridge native rtp.c: Fail native bridge if no framing match (asterisk[13])

[Bob Cripps]

The correct framing is set in set_caps on an ast_format_cap called 
"peer" defined at the top of set_caps, however I suspect something is 
not being set correctly based on that structure.

I suspect the problem is in set_caps(). It's quite a complex function 
with three ast_format_cap structures in play. The end result being when 
chan_pjsip_get_codecs() is called the resulting ast_format_cap is not 
properly populated



On 2018-11-07 12:14, Joshua Colp wrote:
>
> The nativeformats on the channel are set in set_caps, and the format 
> capabilities structure there is supposed to contain the correct 
> framing. Are you saying that this is not true? If so then that is a 
> bug - the nativeformats on the channel are supposed to contain the 
> correct framing as a result of the SDP negotiation itself, which would 
> then get used in the callback for get_codecs, which should then cause 
> the correct framing to appear in bridge_native_rtp.
>
> View Change <https://gerrit.asterisk.org/10495>
>
> To view, visit change 10495 <https://gerrit.asterisk.org/10495>. To 
> unsubscribe, or for help writing mail filters, visit settings 
> <https://gerrit.asterisk.org/settings>.
>
> Gerrit-Project: asterisk
> Gerrit-Branch: 13
> Gerrit-MessageType: comment
> Gerrit-Change-Id: Ic64b8fc6a140a93fbdb2f97550a40d0ff334e607
> Gerrit-Change-Number: 10495
> Gerrit-PatchSet: 3
> Gerrit-Owner: Robert Cripps <rcripps at voxbone.com>
> Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
> Gerrit-Reviewer: Jenkins2 (1000185)
> Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
> Gerrit-Reviewer: Robert Cripps <rcripps at voxbone.com>
> Gerrit-Comment-Date: Wed, 07 Nov 2018 12:14:21 +0000
> Gerrit-HasComments: No
> Gerrit-HasLabels: No

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181107/0b8b5277/attachment.html>