<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>The correct framing is set in set_caps on an ast_format_cap
called "peer" defined at the top of set_caps, however I suspect
something is not being set correctly based on that structure.</p>
<p>I suspect the problem is in set_caps(). It's quite a complex
function with three ast_format_cap structures in play. The end
result being when chan_pjsip_get_codecs() is called the resulting
ast_format_cap is not properly populated</p>
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 2018-11-07 12:14, Joshua Colp wrote:<br>
</div>
<blockquote type="cite"
cite="mid:E1gKMiz-0008F5-EM@gerrit.digium.api">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<p style="white-space: pre-wrap; word-wrap: break-word;">The nativeformats on the channel are set in set_caps, and the format capabilities structure there is supposed to contain the correct framing. Are you saying that this is not true? If so then that is a bug - the nativeformats on the channel are supposed to contain the correct framing as a result of the SDP negotiation itself, which would then get used in the callback for get_codecs, which should then cause the correct framing to appear in bridge_native_rtp.</p>
<p><a href="https://gerrit.asterisk.org/10495"
moz-do-not-send="true">View Change</a></p>
<p>To view, visit <a href="https://gerrit.asterisk.org/10495"
moz-do-not-send="true">change 10495</a>. To unsubscribe, or
for help writing mail filters, visit <a
href="https://gerrit.asterisk.org/settings"
moz-do-not-send="true">settings</a>.</p>
<div itemscope="" itemtype="http://schema.org/EmailMessage">
<div itemscope="" itemprop="action"
itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://gerrit.asterisk.org/10495">
<meta itemprop="name" content="View Change">
</div>
</div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id:
Ic64b8fc6a140a93fbdb2f97550a40d0ff334e607 </div>
<div style="display:none"> Gerrit-Change-Number: 10495 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Robert Cripps
<a class="moz-txt-link-rfc2396E" href="mailto:rcripps@voxbone.com"><rcripps@voxbone.com></a> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph
<a class="moz-txt-link-rfc2396E" href="mailto:gjoseph@digium.com"><gjoseph@digium.com></a> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp
<a class="moz-txt-link-rfc2396E" href="mailto:jcolp@digium.com"><jcolp@digium.com></a> </div>
<div style="display:none"> Gerrit-Reviewer: Robert Cripps
<a class="moz-txt-link-rfc2396E" href="mailto:rcripps@voxbone.com"><rcripps@voxbone.com></a> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 07 Nov 2018
12:14:21 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-HasLabels: No </div>
</blockquote>
<br>
</body>
</html>