[Asterisk-code-review] bridge native rtp.c: Fail native bridge if no framing match (asterisk[13])

[Joshua C. Colp]

Can you ensure you respond in Gerrit itself? These responses only go to George and I, as the code review list is a protected list so noone else can see the responses.

On Wed, Nov 7, 2018, at 11:09 AM, Bob Cripps wrote:
> The correct framing is set in set_caps on an ast_format_cap called 
> "peer" defined at the top of set_caps, however I suspect something is 
> not being set correctly based on that structure.
> 
> I suspect the problem is in set_caps(). It's quite a complex function 
> with three ast_format_cap structures in play. The end result being when 
> chan_pjsip_get_codecs() is called the resulting ast_format_cap is not 
> properly populated
> 
> 
> 
> On 2018-11-07 12:14, Joshua Colp wrote:
> >
> > The nativeformats on the channel are set in set_caps, and the format 
> > capabilities structure there is supposed to contain the correct 
> > framing. Are you saying that this is not true? If so then that is a 
> > bug - the nativeformats on the channel are supposed to contain the 
> > correct framing as a result of the SDP negotiation itself, which would 
> > then get used in the callback for get_codecs, which should then cause 
> > the correct framing to appear in bridge_native_rtp.
> >
> > View Change <https://gerrit.asterisk.org/10495>
> >
> > To view, visit change 10495 <https://gerrit.asterisk.org/10495>. To 
> > unsubscribe, or for help writing mail filters, visit settings 
> > <https://gerrit.asterisk.org/settings>.
> >
> > Gerrit-Project: asterisk
> > Gerrit-Branch: 13
> > Gerrit-MessageType: comment
> > Gerrit-Change-Id: Ic64b8fc6a140a93fbdb2f97550a40d0ff334e607
> > Gerrit-Change-Number: 10495
> > Gerrit-PatchSet: 3
> > Gerrit-Owner: Robert Cripps <rcripps at voxbone.com>
> > Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
> > Gerrit-Reviewer: Jenkins2 (1000185)
> > Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
> > Gerrit-Reviewer: Robert Cripps <rcripps at voxbone.com>
> > Gerrit-Comment-Date: Wed, 07 Nov 2018 12:14:21 +0000
> > Gerrit-HasComments: No
> > Gerrit-HasLabels: No
> 


-- 
Joshua C. Colp
Digium - A Sangoma Company | Senior Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - US
Check us out at: www.digium.com & www.asterisk.org