[Asterisk-code-review] Begin work on python3 compatability. (testsuite[master])
Kevin Harwell
asteriskteam at digium.com
Thu May 10 11:31:09 CDT 2018
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/8854 )
Change subject: Begin work on python3 compatability.
......................................................................
Patch Set 4: Code-Review-1
(8 comments)
https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-backtrace.txt
File lib/python/asterisk/self_test/locks-backtrace.txt:
https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-backtrace.txt@1
PS4, Line 1: === ---> Lock #1 (astobj2.c): MUTEX 657 internal_ao2_callback c 0x2aaaac491f50 (1)
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_bt_get_addresses+0x1a) [0x4e9679]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(__ast_pthread_mutex_lock+0xf6) [0x4e22d9]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(__ao2_lock+0x53) [0x4456fc]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk [0x4464be]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(__ao2_callback+0x59) [0x446a4e]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(__ao2_find+0x2b) [0x446ba7]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk [0x46d3a7]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_channel_get_by_name+0x24) [0x46d3e3]
: /usr/local/asterisk-1.8.6.0/lib/asterisk/modules/func_channel.so [0x2aaabfba2468]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_func_write+0x16a) [0x50aacd]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(pbx_builtin_setvar_helper+0x10e) [0x51fff4]
: /usr/local/asterisk-1.8.6.0/lib/asterisk/modules/chan_sip.so [0x2aaabe422d09]
: /usr/local/asterisk-1.8.6.0/lib/asterisk/modules/chan_sip.so [0x2aaabe4240a0]
: /usr/local/asterisk-1.8.6.0/lib/asterisk/modules/chan_sip.so [0x2aaabe423cf1]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_io_wait+0x1ba) [0x4dc2e4]
: /usr/local/asterisk-1.8.6.0/lib/asterisk/modules/chan_sip.so [0x2aaabe425722]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk [0x5661c6]
: /lib64/libpthread.so.0 [0x3d1d80673d]
: /lib64/libc.so.6(clone+0x6d) [0x3d1ccd44bd]
I think this file got accidentally added.
https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-fail.txt
File lib/python/asterisk/self_test/locks-fail.txt:
https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-fail.txt@1
PS4, Line 1: =======================================================================
: === Currently Held Locks ==============================================
: =======================================================================
: ===
: === <pending> <lock#> (<file>): <lock type> <line num> <function> <lock name> <lock addr> (times locked)
: ===
: === Thread ID: 0x402c6940 (do_monitor started at [25114] chan_sip.c restart_monitor())
: === ---> Lock #0 (chan_sip.c): MUTEX 24629 handle_request_do &netlock 0x2aaabe671a40 (1)
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_bt_get_addresses+0x1a) [0x4e9679]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(__ast_pthread_mutex_lock+0xf6) [0x4e22d9]
: /usr/local/asterisk-1.8.6.0/lib/asterisk/modules/chan_sip.so [0x2aaabe423ee8]
: === ---> Lock #1 (chan_sip.c): MUTEX 24629 handle_request_do &netlock 0x2aaabe671a40 (1)
: === --- ---> Locked Here: channel.c line 4304 (ast_indicate_data)
: === -------------------------------------------------------------------
: ===
: === Thread ID: 0x449ec940 (netconsole started at [ 1351] asterisk.c listener())
: === ---> Waiting for Lock #0 (astobj2.c): MUTEX 842 internal_ao2_iterator_next a->c 0x2aaaac491f50 (1)
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_bt_get_addresses+0x1a) [0x4e9679]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(__ast_pthread_mutex_lock+0xf6) [0x4e22d9]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(__ao2_lock+0x53) [0x4456fc]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk [0x446cec]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(__ao2_iterator_next+0x29) [0x447134]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_channel_iterator_next+0x19) [0x46cf7d]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk [0x489e43]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_cli_command_full+0x222) [0x48eec4]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_cli_command_multiple_full+0x92) [0x48f035]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk [0x43d129]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk [0x5661c6]
: /lib64/libpthread.so.0 [0x3d1d80673d]
: /lib64/libc.so.6(clone+0x6d) [0x3d1ccd44bd]
: === --- ---> Locked Here: astobj2.c line 657 (internal_ao2_callback)
: === -------------------------------------------------------------------
: ===
: === Thread ID: 0x44a68940 (netconsole started at [ 1351] asterisk.c listener())
: === ---> Waiting for Lock #0 (astobj2.c): MUTEX 842 internal_ao2_iterator_next a->c 0x2aaaac491f50 (1)
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_bt_get_addresses+0x1a) [0x4e9679]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(__ast_pthread_mutex_lock+0xf6) [0x4e22d9]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(__ao2_lock+0x53) [0x4456fc]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk [0x446cec]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(__ao2_iterator_next+0x29) [0x447134]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_channel_iterator_next+0x19) [0x46cf7d]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk [0x489e43]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_cli_command_full+0x222) [0x48eec4]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_cli_command_multiple_full+0x92) [0x48f035]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk [0x43d129]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk [0x5661c6]
: /lib64/libpthread.so.0 [0x3d1d80673d]
: /lib64/libc.so.6(clone+0x6d) [0x3d1ccd44bd]
: === --- ---> Locked Here: astobj2.c line 657 (internal_ao2_callback)
: === -------------------------------------------------------------------
: ===
: =======================================================================
Another accidental addition
https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-large-multiple-object.txt
File lib/python/asterisk/self_test/locks-large-multiple-object.txt:
https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-large-multiple-object.txt@1
PS4, Line 1: === Thread ID: 0x449ec940 (netconsole started at [ 1351] asterisk.c listener())
: === ---> Waiting for Lock #0 (astobj2.c): MUTEX 842 internal_ao2_iterator_next a->c 0x2aaaac491f50 (1)
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_bt_get_addresses+0x1a) [0x4e9679]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(__ast_pthread_mutex_lock+0xf6) [0x4e22d9]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(__ao2_lock+0x53) [0x4456fc]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk [0x446cec]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(__ao2_iterator_next+0x29) [0x447134]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_channel_iterator_next+0x19) [0x46cf7d]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk [0x489e43]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_cli_command_full+0x222) [0x48eec4]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_cli_command_multiple_full+0x92) [0x48f035]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk [0x43d129]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk [0x5661c6]
: /lib64/libpthread.so.0 [0x3d1d80673d]
: /lib64/libc.so.6(clone+0x6d) [0x3d1ccd44bd]
: === --- ---> Locked Here: astobj2.c line 657 (internal_ao2_callback)
here too.
https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-multiple-objects-no-backtrace.txt
File lib/python/asterisk/self_test/locks-multiple-objects-no-backtrace.txt:
https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-multiple-objects-no-backtrace.txt@1
PS4, Line 1: === Thread ID: 0x402c6940 (do_monitor started at [25114] chan_sip.c restart_monitor())
: === ---> Lock #0 (chan_sip.c): MUTEX 24629 handle_request_do &netlock 0x2aaabe671a40 (1)
: === ---> Lock #1 (astobj2.c): MUTEX 657 internal_ao2_callback c 0x2aaaac491f50 (1)
: === ---> Waiting for Lock #2 (channel.c): MUTEX 1691 ast_channel_cmp_cb chan 0x2aaaacd3a4e0 (1)
: === --- ---> Locked Here: channel.c line 4304 (ast_indicate_data)
more backtraces.
https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-pass.txt
File lib/python/asterisk/self_test/locks-pass.txt:
https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-pass.txt@1
PS4, Line 1: =======================================================================
: === Currently Held Locks ==============================================
: =======================================================================
: ===
: === <pending> <lock#> (<file>): <lock type> <line num> <function> <lock name> <lock addr> (times locked)
: ===
: ===
: =======================================================================
delete this as well.
https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-single-object-no-held-info.txt
File lib/python/asterisk/self_test/locks-single-object-no-held-info.txt:
https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-single-object-no-held-info.txt@1
PS4, Line 1: === Thread ID: 0x7f668c142700 (do_monitor started at [25915] chan_sip.c restart_monitor())
: === ---> Lock #0 (chan_sip.c): MUTEX 25390 handle_request_do &netlock 0x7f6652193900 (1)
: main/logger.c:1302 ast_bt_get_addresses() (0x505e53+1D)
: main/lock.c:193 __ast_pthread_mutex_lock() (0x4fe55c+D9)
: channels/chan_sip.c:25393 handle_request_do()
: channels/chan_sip.c:25352 sipsock_read()
: main/io.c:288 ast_io_wait() (0x4f8228+19C)
: channels/chan_sip.c:25882 do_monitor()
: main/utils.c:1010 dummy_start()
: libpthread.so.0 <unknown>()
: libc.so.6 clone() (0x31be0e0bc0+6D)
delete
https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-single-object.txt
File lib/python/asterisk/self_test/locks-single-object.txt:
https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-single-object.txt@1
PS4, Line 1: === Thread ID: 0x402c6940 (do_monitor started at [25114] chan_sip.c restart_monitor())
: === ---> Lock #0 (chan_sip.c): MUTEX 24629 handle_request_do &netlock 0x2aaabe671a40 (1)
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_bt_get_addresses+0x1a) [0x4e9679]
: /usr/local/asterisk-1.8.6.0/sbin/asterisk(__ast_pthread_mutex_lock+0xf6) [0x4e22d9]
: /usr/local/asterisk-1.8.6.0/lib/asterisk/modules/chan_sip.so [0x2aaabe423ee8]
: === --- ---> Locked Here: channel.c line 4304 (ast_indicate_data)
moar
https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/test_sip_dialog_test_condition.py.txt
File lib/python/asterisk/self_test/test_sip_dialog_test_condition.py.txt:
https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/test_sip_dialog_test_condition.py.txt@1
PS4, Line 1: #!/usr/bin/env python
: """Test condition for verifying SIP dialogs unit tests
:
: Copyright (C) 2011-2012, Digium, Inc.
: Matt Jordan <mjordan at digium.com>
:
: This program is free software, distributed under the terms of
: the GNU General Public License Version 2.
: """
Leftover file? probably can be deleted
--
To view, visit https://gerrit.asterisk.org/8854
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If76c2d3e11e4ab4552d0df7841287c8bb2de7918
Gerrit-Change-Number: 8854
Gerrit-PatchSet: 4
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 10 May 2018 16:31:09 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180510/3de3c454/attachment-0001.html>
More information about the asterisk-code-review
mailing list