<p>Kevin Harwell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8854">View Change</a></p><p>Patch set 4:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(8 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-backtrace.txt">File lib/python/asterisk/self_test/locks-backtrace.txt:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-backtrace.txt@1">Patch Set #4, Line 1:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">=== ---> Lock #1 (astobj2.c): MUTEX 657 internal_ao2_callback c 0x2aaaac491f50 (1)<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_bt_get_addresses+0x1a) [0x4e9679]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(__ast_pthread_mutex_lock+0xf6) [0x4e22d9]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(__ao2_lock+0x53) [0x4456fc]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk [0x4464be]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(__ao2_callback+0x59) [0x446a4e]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(__ao2_find+0x2b) [0x446ba7]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk [0x46d3a7]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_channel_get_by_name+0x24) [0x46d3e3]<br>/usr/local/asterisk-1.8.6.0/lib/asterisk/modules/func_channel.so [0x2aaabfba2468]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_func_write+0x16a) [0x50aacd]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(pbx_builtin_setvar_helper+0x10e) [0x51fff4]<br>/usr/local/asterisk-1.8.6.0/lib/asterisk/modules/chan_sip.so [0x2aaabe422d09]<br>/usr/local/asterisk-1.8.6.0/lib/asterisk/modules/chan_sip.so [0x2aaabe4240a0]<br>/usr/local/asterisk-1.8.6.0/lib/asterisk/modules/chan_sip.so [0x2aaabe423cf1]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_io_wait+0x1ba) [0x4dc2e4]<br>/usr/local/asterisk-1.8.6.0/lib/asterisk/modules/chan_sip.so [0x2aaabe425722]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk [0x5661c6]<br>/lib64/libpthread.so.0 [0x3d1d80673d]<br>/lib64/libc.so.6(clone+0x6d) [0x3d1ccd44bd]<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think this file got accidentally added.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-fail.txt">File lib/python/asterisk/self_test/locks-fail.txt:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-fail.txt@1">Patch Set #4, Line 1:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">=======================================================================<br>=== Currently Held Locks ==============================================<br>=======================================================================<br>===<br>=== <pending> <lock#> (<file>): <lock type> <line num> <function> <lock name> <lock addr> (times locked)<br>===<br>=== Thread ID: 0x402c6940 (do_monitor started at [25114] chan_sip.c restart_monitor())<br>=== ---> Lock #0 (chan_sip.c): MUTEX 24629 handle_request_do &netlock 0x2aaabe671a40 (1)<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_bt_get_addresses+0x1a) [0x4e9679]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(__ast_pthread_mutex_lock+0xf6) [0x4e22d9]<br>/usr/local/asterisk-1.8.6.0/lib/asterisk/modules/chan_sip.so [0x2aaabe423ee8]<br>=== ---> Lock #1 (chan_sip.c): MUTEX 24629 handle_request_do &netlock 0x2aaabe671a40 (1)<br>=== --- ---> Locked Here: channel.c line 4304 (ast_indicate_data)<br>=== -------------------------------------------------------------------<br>===<br>=== Thread ID: 0x449ec940 (netconsole started at [ 1351] asterisk.c listener())<br>=== ---> Waiting for Lock #0 (astobj2.c): MUTEX 842 internal_ao2_iterator_next a->c 0x2aaaac491f50 (1)<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_bt_get_addresses+0x1a) [0x4e9679]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(__ast_pthread_mutex_lock+0xf6) [0x4e22d9]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(__ao2_lock+0x53) [0x4456fc]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk [0x446cec]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(__ao2_iterator_next+0x29) [0x447134]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_channel_iterator_next+0x19) [0x46cf7d]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk [0x489e43]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_cli_command_full+0x222) [0x48eec4]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_cli_command_multiple_full+0x92) [0x48f035]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk [0x43d129]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk [0x5661c6]<br>/lib64/libpthread.so.0 [0x3d1d80673d]<br>/lib64/libc.so.6(clone+0x6d) [0x3d1ccd44bd]<br>=== --- ---> Locked Here: astobj2.c line 657 (internal_ao2_callback)<br>=== -------------------------------------------------------------------<br>===<br>=== Thread ID: 0x44a68940 (netconsole started at [ 1351] asterisk.c listener())<br>=== ---> Waiting for Lock #0 (astobj2.c): MUTEX 842 internal_ao2_iterator_next a->c 0x2aaaac491f50 (1)<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_bt_get_addresses+0x1a) [0x4e9679]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(__ast_pthread_mutex_lock+0xf6) [0x4e22d9]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(__ao2_lock+0x53) [0x4456fc]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk [0x446cec]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(__ao2_iterator_next+0x29) [0x447134]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_channel_iterator_next+0x19) [0x46cf7d]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk [0x489e43]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_cli_command_full+0x222) [0x48eec4]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_cli_command_multiple_full+0x92) [0x48f035]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk [0x43d129]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk [0x5661c6]<br>/lib64/libpthread.so.0 [0x3d1d80673d]<br>/lib64/libc.so.6(clone+0x6d) [0x3d1ccd44bd]<br>=== --- ---> Locked Here: astobj2.c line 657 (internal_ao2_callback)<br>=== -------------------------------------------------------------------<br>===<br>=======================================================================<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Another accidental addition</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-large-multiple-object.txt">File lib/python/asterisk/self_test/locks-large-multiple-object.txt:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-large-multiple-object.txt@1">Patch Set #4, Line 1:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">=== Thread ID: 0x449ec940 (netconsole started at [ 1351] asterisk.c listener())<br>=== ---> Waiting for Lock #0 (astobj2.c): MUTEX 842 internal_ao2_iterator_next a->c 0x2aaaac491f50 (1)<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_bt_get_addresses+0x1a) [0x4e9679]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(__ast_pthread_mutex_lock+0xf6) [0x4e22d9]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(__ao2_lock+0x53) [0x4456fc]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk [0x446cec]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(__ao2_iterator_next+0x29) [0x447134]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_channel_iterator_next+0x19) [0x46cf7d]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk [0x489e43]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_cli_command_full+0x222) [0x48eec4]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_cli_command_multiple_full+0x92) [0x48f035]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk [0x43d129]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk [0x5661c6]<br>/lib64/libpthread.so.0 [0x3d1d80673d]<br>/lib64/libc.so.6(clone+0x6d) [0x3d1ccd44bd]<br>=== --- ---> Locked Here: astobj2.c line 657 (internal_ao2_callback)<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">here too.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-multiple-objects-no-backtrace.txt">File lib/python/asterisk/self_test/locks-multiple-objects-no-backtrace.txt:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-multiple-objects-no-backtrace.txt@1">Patch Set #4, Line 1:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">=== Thread ID: 0x402c6940 (do_monitor started at [25114] chan_sip.c restart_monitor())<br>=== ---> Lock #0 (chan_sip.c): MUTEX 24629 handle_request_do &netlock 0x2aaabe671a40 (1)<br>=== ---> Lock #1 (astobj2.c): MUTEX 657 internal_ao2_callback c 0x2aaaac491f50 (1)<br>=== ---> Waiting for Lock #2 (channel.c): MUTEX 1691 ast_channel_cmp_cb chan 0x2aaaacd3a4e0 (1)<br>=== --- ---> Locked Here: channel.c line 4304 (ast_indicate_data)<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">more backtraces.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-pass.txt">File lib/python/asterisk/self_test/locks-pass.txt:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-pass.txt@1">Patch Set #4, Line 1:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">=======================================================================<br>=== Currently Held Locks ==============================================<br>=======================================================================<br>===<br>=== <pending> <lock#> (<file>): <lock type> <line num> <function> <lock name> <lock addr> (times locked)<br>===<br>===<br>=======================================================================<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">delete this as well.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-single-object-no-held-info.txt">File lib/python/asterisk/self_test/locks-single-object-no-held-info.txt:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-single-object-no-held-info.txt@1">Patch Set #4, Line 1:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">=== Thread ID: 0x7f668c142700 (do_monitor started at [25915] chan_sip.c restart_monitor())<br>=== ---> Lock #0 (chan_sip.c): MUTEX 25390 handle_request_do &netlock 0x7f6652193900 (1)<br>main/logger.c:1302 ast_bt_get_addresses() (0x505e53+1D)<br>main/lock.c:193 __ast_pthread_mutex_lock() (0x4fe55c+D9)<br>channels/chan_sip.c:25393 handle_request_do()<br>channels/chan_sip.c:25352 sipsock_read()<br>main/io.c:288 ast_io_wait() (0x4f8228+19C)<br>channels/chan_sip.c:25882 do_monitor()<br>main/utils.c:1010 dummy_start()<br>libpthread.so.0 <unknown>()<br>libc.so.6 clone() (0x31be0e0bc0+6D)<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">delete</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-single-object.txt">File lib/python/asterisk/self_test/locks-single-object.txt:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/locks-single-object.txt@1">Patch Set #4, Line 1:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">=== Thread ID: 0x402c6940 (do_monitor started at [25114] chan_sip.c restart_monitor())<br>=== ---> Lock #0 (chan_sip.c): MUTEX 24629 handle_request_do &netlock 0x2aaabe671a40 (1)<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(ast_bt_get_addresses+0x1a) [0x4e9679]<br>/usr/local/asterisk-1.8.6.0/sbin/asterisk(__ast_pthread_mutex_lock+0xf6) [0x4e22d9]<br>/usr/local/asterisk-1.8.6.0/lib/asterisk/modules/chan_sip.so [0x2aaabe423ee8]<br>=== --- ---> Locked Here: channel.c line 4304 (ast_indicate_data)<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">moar</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/test_sip_dialog_test_condition.py.txt">File lib/python/asterisk/self_test/test_sip_dialog_test_condition.py.txt:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/test_sip_dialog_test_condition.py.txt@1">Patch Set #4, Line 1:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">#!/usr/bin/env python<br>"""Test condition for verifying SIP dialogs unit tests<br><br>Copyright (C) 2011-2012, Digium, Inc.<br>Matt Jordan <mjordan@digium.com><br><br>This program is free software, distributed under the terms of<br>the GNU General Public License Version 2.<br>"""<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Leftover file? probably can be deleted</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8854">change 8854</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8854"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: If76c2d3e11e4ab4552d0df7841287c8bb2de7918 </div>
<div style="display:none"> Gerrit-Change-Number: 8854 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 10 May 2018 16:31:09 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>