[Asterisk-code-review] Begin work on python3 compatability. (testsuite[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8854 )

Change subject: Begin work on python3 compatability.
......................................................................


Patch Set 4:

(1 comment)

All of the locks-* files are intentional, they are read by test_lock_test_condition.py to simulate output from Asterisk.  They were previously in test_lock_test_condition.py but caused a bunch of pep8 errors about excessively long lines (and lib/python/asterisk/self_test is now fully pep8 compliant).

https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/test_sip_dialog_test_condition.py.txt
File lib/python/asterisk/self_test/test_sip_dialog_test_condition.py.txt:

https://gerrit.asterisk.org/#/c/8854/4/lib/python/asterisk/self_test/test_sip_dialog_test_condition.py.txt@1
PS4, Line 1: #!/usr/bin/env python
           : """Test condition for verifying SIP dialogs unit tests
           : 
           : Copyright (C) 2011-2012, Digium, Inc.
           : Matt Jordan <mjordan at digium.com>
           : 
           : This program is free software, distributed under the terms of
           : the GNU General Public License Version 2.
           : """
> Leftover file? probably can be deleted
Not really.  lib/python/asterisk/sip_dialog_test_condition.py exists, but it's broken.  Therefore this test does not work.  I didn't want to address the pep8 / pyflakes8 issues on a broken test, but I also didn't want to just delete it.  If wanted I can delete this test in a follow-up commit, that way it'll be in the history of lib/python/asterisk/self_test.  Same with lib/python/asterisk/sip_dialog_test_condition.py, it's broken (even before this review) so it could be deleted?  Again think deleting it should be done in a separate commit from the python3-compat patch.



-- 
To view, visit https://gerrit.asterisk.org/8854
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If76c2d3e11e4ab4552d0df7841287c8bb2de7918
Gerrit-Change-Number: 8854
Gerrit-PatchSet: 4
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 10 May 2018 16:38:54 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180510/fd41cd24/attachment.html>