[Asterisk-code-review] BuildSystem: Instead of $PJPROJECT LIBS with s, use $PJPROJE... (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/8473 )

Change subject: BuildSystem: Instead of $PJPROJECT_LIBS with s, use $PJPROJECT_LIB everywhere.
......................................................................


Patch Set 2:

> Cannot work with that code review. I did not and do not find any
 > other PJPROJECT_LIBs in the code base. If you find more, please,
 > explain *exactly* where and how you find it. Even one concrete
 > example is enough.
 > 
 > Furthermore, the statements/changes in the script ./configure are
 > obvious. However, I do not know if you do not know yourself if that
 > is the same for the Makefile. In other words: Are you guessing
 > about the change of the Makefile – somebody has to re-test – or do
 > you say the change in the Makefile must be avoided for sure?

Sorry if I wasn't clear.

./configure:664:PJPROJECT_LIBS
./configure:1449:PJPROJECT_LIBS
./configure:2201:  PJPROJECT_LIBS
./configure:24490:if test -n "$PJPROJECT_LIBS"; then
./configure:24491:    pkg_cv_PJPROJECT_LIBS="$PJPROJECT_LIBS"
./configure:24499:  pkg_cv_PJPROJECT_LIBS=`$PKG_CONFIG --libs "libpjproject" 2>/dev/null`
./configure:24540:	PJPROJECT_LIBS=$pkg_cv_PJPROJECT_LIBS
./configure:24546:            PJPROJECT_LIB="$PJPROJECT_LIBS"

I'm not sure why PJPROJECT_LIBS is still showing up in configure but it needs to be investigated.

I'm asking you to test and confirm that when configured --with-pjproject-bundled and built, the res/res_pjsip modules do NOT link to any libpj* libraries directly, that only main/libasteriskpj.so does, and that main/asterisk links to libasteriskpj.so.  Then test and confirm that when configured --without-pjproject-bundled and built, the res/res_pjsip modules DO link to the system installed libpj* libraries, libasteriskpj.so isn't built, and that main/asterisk does NOT link to any libpj* libraries.


-- 
To view, visit https://gerrit.asterisk.org/8473
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I7359860a5d730cdc784c2c48e501a082196434d3
Gerrit-Change-Number: 8473
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 14 Mar 2018 12:36:56 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180314/97cb39cc/attachment.html>