<p>George Joseph <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8473">View Change</a></p><p>Patch set 2:</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Cannot work with that code review. I did not and do not find any<br>other PJPROJECT_LIBs in the code base. If you find more, please,<br>explain *exactly* where and how you find it. Even one concrete<br>example is enough.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Furthermore, the statements/changes in the script ./configure are<br>obvious. However, I do not know if you do not know yourself if that<br>is the same for the Makefile. In other words: Are you guessing<br>about the change of the Makefile – somebody has to re-test – or do<br>you say the change in the Makefile must be avoided for sure?</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Sorry if I wasn't clear.</p><p style="white-space: pre-wrap; word-wrap: break-word;">./configure:664:PJPROJECT_LIBS<br>./configure:1449:PJPROJECT_LIBS<br>./configure:2201:  PJPROJECT_LIBS<br>./configure:24490:if test -n "$PJPROJECT_LIBS"; then<br>./configure:24491:    pkg_cv_PJPROJECT_LIBS="$PJPROJECT_LIBS"<br>./configure:24499:  pkg_cv_PJPROJECT_LIBS=`$PKG_CONFIG --libs "libpjproject" 2>/dev/null`<br>./configure:24540:     PJPROJECT_LIBS=$pkg_cv_PJPROJECT_LIBS<br>./configure:24546:            PJPROJECT_LIB="$PJPROJECT_LIBS"</p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm not sure why PJPROJECT_LIBS is still showing up in configure but it needs to be investigated.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm asking you to test and confirm that when configured --with-pjproject-bundled and built, the res/res_pjsip modules do NOT link to any libpj* libraries directly, that only main/libasteriskpj.so does, and that main/asterisk links to libasteriskpj.so.  Then test and confirm that when configured --without-pjproject-bundled and built, the res/res_pjsip modules DO link to the system installed libpj* libraries, libasteriskpj.so isn't built, and that main/asterisk does NOT link to any libpj* libraries.</p><ul style="list-style: none; padding-left: 20px;"></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8473">change 8473</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8473"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I7359860a5d730cdc784c2c48e501a082196434d3 </div>
<div style="display:none"> Gerrit-Change-Number: 8473 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Alexander Traud <pabstraud@compuserve.com> </div>
<div style="display:none"> Gerrit-Reviewer: Alexander Traud <pabstraud@compuserve.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 14 Mar 2018 12:36:56 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>