[Asterisk-code-review] BuildSystem: Instead of $PJPROJECT LIBS with s, use $PJPROJE... (asterisk[13])

Alexander Traud asteriskteam at digium.com
Wed Mar 14 03:09:03 CDT 2018


Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/8473 )

Change subject: BuildSystem: Instead of $PJPROJECT_LIBS with s, use $PJPROJECT_LIB everywhere.
......................................................................


Patch Set 2:

Cannot work with that code review. I did not and do not find any other PJPROJECT_LIBs in the code base. If you find more, please, explain *exactly* where and how you find it. Even one concrete example is enough.

Furthermore, the statements/changes in the script ./configure are obvious. However, I do not know if you do not know yourself if that is the same for the Makefile. In other words: Are you guessing about the change of the Makefile – somebody has to re-test – or do you say the change in the Makefile must be avoided for sure?


-- 
To view, visit https://gerrit.asterisk.org/8473
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I7359860a5d730cdc784c2c48e501a082196434d3
Gerrit-Change-Number: 8473
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 14 Mar 2018 08:09:03 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180314/cd2e7c32/attachment.html>


More information about the asterisk-code-review mailing list