[Asterisk-code-review] BuildSystem: Instead of $PJPROJECT LIBS with s, use $PJPROJE... (asterisk[13])

George Joseph asteriskteam at digium.com
Tue Mar 13 16:41:43 CDT 2018


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/8473 )

Change subject: BuildSystem: Instead of $PJPROJECT_LIBS with s, use $PJPROJECT_LIB everywhere.
......................................................................


Patch Set 2: Code-Review-1

There was a reason for LIBS and LIB.  LIBS is used by libpjproject to link in a system version of pjproject.  LIB is used by the modules.  You need to make sure this all still works with and without bundled.

Also, I still find lots of references to PJPROJECT_LIBS in the codebase after this patch.


-- 
To view, visit https://gerrit.asterisk.org/8473
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I7359860a5d730cdc784c2c48e501a082196434d3
Gerrit-Change-Number: 8473
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 13 Mar 2018 21:41:43 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180313/0b5cd684/attachment.html>


More information about the asterisk-code-review mailing list