[Asterisk-code-review] app confbridge: Move participant info code to confbridge ma... (asterisk[15])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/9294 )

Change subject: app_confbridge:  Move participant info code to confbridge_manager.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/9294/1/apps/confbridge/confbridge_manager.c
File apps/confbridge/confbridge_manager.c:

https://gerrit.asterisk.org/#/c/9294/1/apps/confbridge/confbridge_manager.c@619
PS1, Line 619: 		struct confbridge_conference *conference = conf_find_bridge(conference_name);
> Race conditions when using the stasis message bus for the event
 > distribution:
 > 
 > You are assuming you will find a live conference from information
 > in a stasis message.  You need to prepare for the fact that stasis
 > messages are after the fact and not live so the conference may not
 > exist anymore.

fixed.

 > 
 > For the join event you may get the event before the channel has
 > actually joined the bridge where bridge_channel gets set on the
 > channel.
 > 

known already.  handled in send_event_to_participants.

 > For the leave event you will always get the event after the channel
 > has left the bridge and the bridge_channel no longer exists on the
 > channel.

known already.  handled in send_event_to_participants.


https://gerrit.asterisk.org/#/c/9294/1/apps/confbridge/confbridge_manager.c@624
PS1, Line 624: 			struct ast_channel *chan = ast_channel_get_by_name(blob->channel->name);
> The same goes for getting a live channel using information in a
 > stasis message.  You need to be prepared for the channel to no
 > longer exist.

known already.  handled in send_event_to_participants.



-- 
To view, visit https://gerrit.asterisk.org/9294
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I228806ac153074f45e0b35d5236166e92e132abd
Gerrit-Change-Number: 9294
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 26 Jun 2018 21:17:10 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180626/e65bc204/attachment.html>