<p>George Joseph <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/9294">View Change</a></p><p>Patch set 1:</p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/9294/1/apps/confbridge/confbridge_manager.c">File apps/confbridge/confbridge_manager.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9294/1/apps/confbridge/confbridge_manager.c@619">Patch Set #1, Line 619:</a> <code style="font-family:monospace,monospace">            struct confbridge_conference *conference = conf_find_bridge(conference_name);</code></p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Race conditions when using the stasis message bus for the event<br>distribution:</p><p style="white-space: pre-wrap; word-wrap: break-word;">You are assuming you will find a live conference from information<br>in a stasis message.  You need to prepare for the fact that stasis<br>messages are after the fact and not live so the conference may not<br>exist anymore.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">fixed.</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;"><br>For the join event you may get the event before the channel has<br>actually joined the bridge where bridge_channel gets set on the<br>channel.<br></p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">known already.  handled in send_event_to_participants.</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">For the leave event you will always get the event after the channel<br>has left the bridge and the bridge_channel no longer exists on the<br>channel.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">known already.  handled in send_event_to_participants.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9294/1/apps/confbridge/confbridge_manager.c@624">Patch Set #1, Line 624:</a> <code style="font-family:monospace,monospace">                  struct ast_channel *chan = ast_channel_get_by_name(blob->channel->name);</code></p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">The same goes for getting a live channel using information in a<br>stasis message.  You need to be prepared for the channel to no<br>longer exist.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">known already.  handled in send_event_to_participants.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/9294">change 9294</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9294"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I228806ac153074f45e0b35d5236166e92e132abd </div>
<div style="display:none"> Gerrit-Change-Number: 9294 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 26 Jun 2018 21:17:10 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>