[Asterisk-code-review] app confbridge: Move participant info code to confbridge ma... (asterisk[15])

George Joseph asteriskteam at digium.com
Tue Jun 26 16:18:24 CDT 2018


Hello Richard Mudgett, Kevin Harwell, Jenkins2, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/9294

to look at the new patch set (#2).

Change subject: app_confbridge:  Move participant info code to confbridge_manager.
......................................................................

app_confbridge:  Move participant info code to confbridge_manager.

With the participant info code in app_confbridge, we were still
in the process of adding the channel to the bridge when trying to send
an in-dialog MESSAGE.  This caused 2 threads to grab the channel
blocking flag at the same time.  To mitigate this, the participant
info code was moved to confbridge_manager so it runs after all
channel/bridge actions have finished.

Change-Id: I228806ac153074f45e0b35d5236166e92e132abd
---
M apps/app_confbridge.c
M apps/confbridge/confbridge_manager.c
M apps/confbridge/include/confbridge.h
3 files changed, 352 insertions(+), 312 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/94/9294/2
-- 
To view, visit https://gerrit.asterisk.org/9294
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I228806ac153074f45e0b35d5236166e92e132abd
Gerrit-Change-Number: 9294
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180626/641cfe83/attachment.html>


More information about the asterisk-code-review mailing list