[Asterisk-code-review] app confbridge: Bridge and announcers not removed if confere... (asterisk[13])

[Robert Mordec]

Robert Mordec has posted comments on this change. ( https://gerrit.asterisk.org/9026 )

Change subject: app_confbridge: Bridge and announcers not removed if conference ends quickly
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/9026/3/apps/app_confbridge.c
File apps/app_confbridge.c:

https://gerrit.asterisk.org/#/c/9026/3/apps/app_confbridge.c@1593
PS3, Line 1593: 		if (ast_taskprocessor_push(conference->playback_queue, push_announcer, &push)) {
> Ah Ha.  After more thought, this patch can be simplified a lot.
You are right! If conference thread waits for the task to finish it might just as well do it itself. And since all tasks to play announcements are pushed from this conference thread, there is no danger that something else might want to play announcement before push_announcer() is finished.



-- 
To view, visit https://gerrit.asterisk.org/9026
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I947a50fb121422d90fd1816d643a54d75185a477
Gerrit-Change-Number: 9026
Gerrit-PatchSet: 3
Gerrit-Owner: Robert Mordec <r.mordec at slican.pl>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Robert Mordec <r.mordec at slican.pl>
Gerrit-Comment-Date: Thu, 21 Jun 2018 10:01:42 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180621/71b81fad/attachment.html>