<p>Robert Mordec <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/9026">View Change</a></p><p>Patch set 3:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/9026/3/apps/app_confbridge.c">File apps/app_confbridge.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9026/3/apps/app_confbridge.c@1593">Patch Set #3, Line 1593:</a> <code style="font-family:monospace,monospace">                if (ast_taskprocessor_push(conference->playback_queue, push_announcer, &push)) {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Ah Ha.  After more thought, this patch can be simplified a lot.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">You are right! If conference thread waits for the task to finish it might just as well do it itself. And since all tasks to play announcements are pushed from this conference thread, there is no danger that something else might want to play announcement before push_announcer() is finished.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/9026">change 9026</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9026"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I947a50fb121422d90fd1816d643a54d75185a477 </div>
<div style="display:none"> Gerrit-Change-Number: 9026 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Robert Mordec <r.mordec@slican.pl> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Robert Mordec <r.mordec@slican.pl> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 21 Jun 2018 10:01:42 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>