[Asterisk-code-review] app confbridge: Bridge and announcers not removed if confere... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/9026 )

Change subject: app_confbridge: Bridge and announcers not removed if conference ends quickly
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/9026/3/apps/app_confbridge.c
File apps/app_confbridge.c:

https://gerrit.asterisk.org/#/c/9026/3/apps/app_confbridge.c@1593
PS3, Line 1593: 		if (ast_taskprocessor_push(conference->playback_queue, push_announcer, &push)) {
Ah Ha.  After more thought, this patch can be simplified a lot.

Simply call push_announcer() here and make push_announcer() not unref the passed conference.  Also the push_announcer() function doxygen would need to be updated.

static int push_announcer(struct confbridge_conference *conference)
{
	if (conf_announce_channel_push(conference->playback_chan)) {
		ast_hangup(conference->playback_chan);
		conference->playback_chan = NULL;
		return -1;
	}

	ast_autoservice_start(conference->playback_chan);
	return 0;
}


...
if (push_announcer(conference)) {
  ...
}
...

There is no need to have the taskprocessor execute push_announcer() as it was always the first thing the taskprocessor did and we really need to wait for the function to complete before continuing in order to fix the bug.



-- 
To view, visit https://gerrit.asterisk.org/9026
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I947a50fb121422d90fd1816d643a54d75185a477
Gerrit-Change-Number: 9026
Gerrit-PatchSet: 3
Gerrit-Owner: Robert Mordec <r.mordec at slican.pl>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Robert Mordec <r.mordec at slican.pl>
Gerrit-Comment-Date: Wed, 20 Jun 2018 16:52:10 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180620/ae56a7f9/attachment.html>