<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/9026">View Change</a></p><p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/9026/3/apps/app_confbridge.c">File apps/app_confbridge.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9026/3/apps/app_confbridge.c@1593">Patch Set #3, Line 1593:</a> <code style="font-family:monospace,monospace">           if (ast_taskprocessor_push(conference->playback_queue, push_announcer, &push)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ah Ha.  After more thought, this patch can be simplified a lot.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Simply call push_announcer() here and make push_announcer() not unref the passed conference.  Also the push_announcer() function doxygen would need to be updated.</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">static int push_announcer(struct confbridge_conference *conference)<br>{<br>     if (conf_announce_channel_push(conference->playback_chan)) {<br>               ast_hangup(conference->playback_chan);<br>             conference->playback_chan = NULL;<br>          return -1;<br>    }</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">     ast_autoservice_start(conference->playback_chan);<br>  return 0;<br>}</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><br>...<br>if (push_announcer(conference)) {<br>  ...<br>}<br>...</pre><p style="white-space: pre-wrap; word-wrap: break-word;">There is no need to have the taskprocessor execute push_announcer() as it was always the first thing the taskprocessor did and we really need to wait for the function to complete before continuing in order to fix the bug.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/9026">change 9026</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9026"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I947a50fb121422d90fd1816d643a54d75185a477 </div>
<div style="display:none"> Gerrit-Change-Number: 9026 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Robert Mordec <r.mordec@slican.pl> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Robert Mordec <r.mordec@slican.pl> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 20 Jun 2018 16:52:10 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>