[Asterisk-code-review] app confbridge: Bridge and announcers not removed if confere... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/9026 )

Change subject: app_confbridge: Bridge and announcers not removed if conference ends quickly
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/9026/2/apps/app_confbridge.c
File apps/app_confbridge.c:

https://gerrit.asterisk.org/#/c/9026/2/apps/app_confbridge.c@1575
PS2, Line 1575: 		if (ast_taskprocessor_push(conference->playback_queue, push_announcer, ao2_bump(conference))) {
Rather than try to track the conference ref counts (which is a really fragile thing to do), rework push_announcer() to be like hangup_playback() and wait here for push_announcer() to complete on the taskprocessor thread before continuing.

destroy_conference_bridge() is the example of how to wait for the pushed hangup_playback() task to complete.

As a follow on patch:
Looks like we could use an ast_taskprocessor_push_sync() function in taskprocessor.c to generically encapsulate this kind of thing since there are now three places in app_confbridge.c where we could use it.  (destroy_conference_bridge(), play_sound_helper(), and here)



-- 
To view, visit https://gerrit.asterisk.org/9026
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I947a50fb121422d90fd1816d643a54d75185a477
Gerrit-Change-Number: 9026
Gerrit-PatchSet: 2
Gerrit-Owner: Robert Mordec <r.mordec at slican.pl>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Robert Mordec <r.mordec at slican.pl>
Gerrit-Comment-Date: Tue, 12 Jun 2018 16:54:47 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180612/fafeae2c/attachment-0001.html>