<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/9026">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/9026/2/apps/app_confbridge.c">File apps/app_confbridge.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9026/2/apps/app_confbridge.c@1575">Patch Set #2, Line 1575:</a> <code style="font-family:monospace,monospace">           if (ast_taskprocessor_push(conference->playback_queue, push_announcer, ao2_bump(conference))) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Rather than try to track the conference ref counts (which is a really fragile thing to do), rework push_announcer() to be like hangup_playback() and wait here for push_announcer() to complete on the taskprocessor thread before continuing.</p><p style="white-space: pre-wrap; word-wrap: break-word;">destroy_conference_bridge() is the example of how to wait for the pushed hangup_playback() task to complete.</p><p style="white-space: pre-wrap; word-wrap: break-word;">As a follow on patch:<br>Looks like we could use an ast_taskprocessor_push_sync() function in taskprocessor.c to generically encapsulate this kind of thing since there are now three places in app_confbridge.c where we could use it.  (destroy_conference_bridge(), play_sound_helper(), and here)</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/9026">change 9026</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9026"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I947a50fb121422d90fd1816d643a54d75185a477 </div>
<div style="display:none"> Gerrit-Change-Number: 9026 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Robert Mordec <r.mordec@slican.pl> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Robert Mordec <r.mordec@slican.pl> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 12 Jun 2018 16:54:47 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>