[Asterisk-code-review] app confbridge: Bridge and announcers not removed if confere... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/9026 )

Change subject: app_confbridge: Bridge and announcers not removed if conference ends quickly
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

I believe the race condition is still possible with this, just eliminated. Richard has been on vacation and is now back, so I'll be asking him to take a look - but I believe a different approach will be needed.

https://gerrit.asterisk.org/#/c/9026/1/apps/app_confbridge.c
File apps/app_confbridge.c:

https://gerrit.asterisk.org/#/c/9026/1/apps/app_confbridge.c@1459
PS1, Line 1459: 
> I admit, in my particular case (bug found in production) I didn't focus on 
I believe the race condition exists, so this fix isn't the correct way to approach it. I'm going to ask Richard Mudgett to take a look to see if he has any suggestions or thoughts as he is more familiar with the interaction.



-- 
To view, visit https://gerrit.asterisk.org/9026
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I947a50fb121422d90fd1816d643a54d75185a477
Gerrit-Change-Number: 9026
Gerrit-PatchSet: 2
Gerrit-Owner: Robert Mordec <r.mordec at slican.pl>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Robert Mordec <r.mordec at slican.pl>
Gerrit-Comment-Date: Tue, 12 Jun 2018 11:48:22 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180612/40a393c2/attachment.html>