[Asterisk-code-review] channel/pjsip/identify/header ordering: Test endpoint identi... (testsuite[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/7937 )

Change subject: channel/pjsip/identify/header_ordering: Test endpoint identification order.
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/7937/1/tests/channels/pjsip/identify/header_ordering_header_ip/configs/ast1/pjsip.conf
File tests/channels/pjsip/identify/header_ordering_header_ip/configs/ast1/pjsip.conf:

https://gerrit.asterisk.org/#/c/7937/1/tests/channels/pjsip/identify/header_ordering_header_ip/configs/ast1/pjsip.conf@3
PS1, Line 3: header,ip
This should be reversed.  Since this is the header test, you also want to make sure the call is NOT matched by ip.


https://gerrit.asterisk.org/#/c/7937/1/tests/channels/pjsip/identify/header_ordering_header_ip/sipp/nominal.xml
File tests/channels/pjsip/identify/header_ordering_header_ip/sipp/nominal.xml:

https://gerrit.asterisk.org/#/c/7937/1/tests/channels/pjsip/identify/header_ordering_header_ip/sipp/nominal.xml@68
PS1, Line 68: 	<!-- definition of the response time repartition table (unit is ms) -->
            : 	<ResponseTimeRepartition value="10, 20, 30, 40, 50, 100, 150, 200"/>
            : 
            : 	<!-- definition of the call length repartition table (unit is ms) -->
            : 	<CallLengthRepartition value="10, 50, 100, 500, 1000, 5000, 10000"/>
Not needed


https://gerrit.asterisk.org/#/c/7937/1/tests/channels/pjsip/identify/header_ordering_ip_header/configs/ast1/pjsip.conf
File tests/channels/pjsip/identify/header_ordering_ip_header/configs/ast1/pjsip.conf:

https://gerrit.asterisk.org/#/c/7937/1/tests/channels/pjsip/identify/header_ordering_ip_header/configs/ast1/pjsip.conf@3
PS1, Line 3: ip,header
This should be reversed.  Since this is the ip test, you also want to make sure that the call is NOT matched by header.


https://gerrit.asterisk.org/#/c/7937/1/tests/channels/pjsip/identify/header_ordering_ip_header/sipp/nominal.xml
File tests/channels/pjsip/identify/header_ordering_ip_header/sipp/nominal.xml:

https://gerrit.asterisk.org/#/c/7937/1/tests/channels/pjsip/identify/header_ordering_ip_header/sipp/nominal.xml@68
PS1, Line 68: 	<!-- definition of the response time repartition table (unit is ms) -->
            : 	<ResponseTimeRepartition value="10, 20, 30, 40, 50, 100, 150, 200"/>
            : 
            : 	<!-- definition of the call length repartition table (unit is ms) -->
            : 	<CallLengthRepartition value="10, 50, 100, 500, 1000, 5000, 10000"/>
These aren't needed.



-- 
To view, visit https://gerrit.asterisk.org/7937
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12560bdcc36f7df170de79e11666fe6b812e67f4
Gerrit-Change-Number: 7937
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Fri, 12 Jan 2018 14:19:50 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180112/19c0f18f/attachment.html>