<p>George Joseph <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7937">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(4 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7937/1/tests/channels/pjsip/identify/header_ordering_header_ip/configs/ast1/pjsip.conf">File tests/channels/pjsip/identify/header_ordering_header_ip/configs/ast1/pjsip.conf:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7937/1/tests/channels/pjsip/identify/header_ordering_header_ip/configs/ast1/pjsip.conf@3">Patch Set #1, Line 3:</a> <code style="font-family:monospace,monospace">header,ip</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should be reversed. Since this is the header test, you also want to make sure the call is NOT matched by ip.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7937/1/tests/channels/pjsip/identify/header_ordering_header_ip/sipp/nominal.xml">File tests/channels/pjsip/identify/header_ordering_header_ip/sipp/nominal.xml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7937/1/tests/channels/pjsip/identify/header_ordering_header_ip/sipp/nominal.xml@68">Patch Set #1, Line 68:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> <!-- definition of the response time repartition table (unit is ms) --><br> <ResponseTimeRepartition value="10, 20, 30, 40, 50, 100, 150, 200"/><br><br> <!-- definition of the call length repartition table (unit is ms) --><br> <CallLengthRepartition value="10, 50, 100, 500, 1000, 5000, 10000"/><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Not needed</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7937/1/tests/channels/pjsip/identify/header_ordering_ip_header/configs/ast1/pjsip.conf">File tests/channels/pjsip/identify/header_ordering_ip_header/configs/ast1/pjsip.conf:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7937/1/tests/channels/pjsip/identify/header_ordering_ip_header/configs/ast1/pjsip.conf@3">Patch Set #1, Line 3:</a> <code style="font-family:monospace,monospace">ip,header</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should be reversed. Since this is the ip test, you also want to make sure that the call is NOT matched by header.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7937/1/tests/channels/pjsip/identify/header_ordering_ip_header/sipp/nominal.xml">File tests/channels/pjsip/identify/header_ordering_ip_header/sipp/nominal.xml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7937/1/tests/channels/pjsip/identify/header_ordering_ip_header/sipp/nominal.xml@68">Patch Set #1, Line 68:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> <!-- definition of the response time repartition table (unit is ms) --><br> <ResponseTimeRepartition value="10, 20, 30, 40, 50, 100, 150, 200"/><br><br> <!-- definition of the call length repartition table (unit is ms) --><br> <CallLengthRepartition value="10, 50, 100, 500, 1000, 5000, 10000"/><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">These aren't needed.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7937">change 7937</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7937"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I12560bdcc36f7df170de79e11666fe6b812e67f4 </div>
<div style="display:none"> Gerrit-Change-Number: 7937 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 12 Jan 2018 14:19:50 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>