[Asterisk-code-review] channel/pjsip/identify/header ordering: Test endpoint identi... (testsuite[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7937 )

Change subject: channel/pjsip/identify/header_ordering: Test endpoint identification order.
......................................................................


Patch Set 1:

(2 comments)

I'll remove the unneeded sections of the normal.xml files Monday.

https://gerrit.asterisk.org/#/c/7937/1/tests/channels/pjsip/identify/header_ordering_header_ip/configs/ast1/pjsip.conf
File tests/channels/pjsip/identify/header_ordering_header_ip/configs/ast1/pjsip.conf:

https://gerrit.asterisk.org/#/c/7937/1/tests/channels/pjsip/identify/header_ordering_header_ip/configs/ast1/pjsip.conf@3
PS1, Line 3: header,ip
> This should be reversed.  Since this is the header test, you also want to m
You have it backwards.  This is the header test so we need to match the incoming call to the header endpoint.

The incoming call request message matches both ip and header identify sections.  Since header is listed *first* in endpoint_identifier_order then the call is matched to the header endpoint first.

The other test is setup to match the other way for the same incoming call request message.


https://gerrit.asterisk.org/#/c/7937/1/tests/channels/pjsip/identify/header_ordering_ip_header/configs/ast1/pjsip.conf
File tests/channels/pjsip/identify/header_ordering_ip_header/configs/ast1/pjsip.conf:

https://gerrit.asterisk.org/#/c/7937/1/tests/channels/pjsip/identify/header_ordering_ip_header/configs/ast1/pjsip.conf@3
PS1, Line 3: ip,header
> This should be reversed.  Since this is the ip test, you also want to make 
You have it backwards.  This is the ip test so we need to match the incoming call to the ip endpoint.

The incoming call request message matches both ip and header identify sections.  Since ip is listed *first* in endpoint_identifier_order then the call is matched to the ip endpoint first.

The other test is setup to match the other way for the same incoming call request message.



-- 
To view, visit https://gerrit.asterisk.org/7937
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12560bdcc36f7df170de79e11666fe6b812e67f4
Gerrit-Change-Number: 7937
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 16:25:46 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180112/cc8bfbd3/attachment-0001.html>