[Asterisk-code-review] res pjsip/config domain aliases.c: Add check for missing dom... (asterisk[15])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8159 )

Change subject: res_pjsip/config_domain_aliases.c: Add check for missing domain.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/8159/1/res/res_pjsip/config_domain_aliases.c
File res/res_pjsip/config_domain_aliases.c:

https://gerrit.asterisk.org/#/c/8159/1/res/res_pjsip/config_domain_aliases.c@64
PS1, Line 64: 		return -1;
I agree with this in theory (and absolutely for master), but what happens in 13.19.0 or 15.2.0 if someone has an alias with an empty alias->domain?  Unless that previously crashed I think we should print the error but not prevent startup of res_pjsip.so.



-- 
To view, visit https://gerrit.asterisk.org/8159
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I98a892016ed61dcf5efeb6619fd748925103f0be
Gerrit-Change-Number: 8159
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Sat, 03 Feb 2018 13:33:48 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180203/49e4e96a/attachment.html>