<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8159">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8159/1/res/res_pjsip/config_domain_aliases.c">File res/res_pjsip/config_domain_aliases.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8159/1/res/res_pjsip/config_domain_aliases.c@64">Patch Set #1, Line 64:</a> <code style="font-family:monospace,monospace">         return -1;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I agree with this in theory (and absolutely for master), but what happens in 13.19.0 or 15.2.0 if someone has an alias with an empty alias->domain?  Unless that previously crashed I think we should print the error but not prevent startup of res_pjsip.so.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8159">change 8159</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8159"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I98a892016ed61dcf5efeb6619fd748925103f0be </div>
<div style="display:none"> Gerrit-Change-Number: 8159 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 03 Feb 2018 13:33:48 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>