[Asterisk-code-review] res pjsip/config domain aliases.c: Add check for missing dom... (asterisk[15])

Richard Mudgett asteriskteam at digium.com
Mon Feb 5 11:57:56 CST 2018


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8159 )

Change subject: res_pjsip/config_domain_aliases.c: Add check for missing domain.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/8159/1/res/res_pjsip/config_domain_aliases.c
File res/res_pjsip/config_domain_aliases.c:

https://gerrit.asterisk.org/#/c/8159/1/res/res_pjsip/config_domain_aliases.c@64
PS1, Line 64: 		return -1;
> I agree with this in theory (and absolutely for master), but what happens i
I think they should fix their configuration and this makes sure they do.



-- 
To view, visit https://gerrit.asterisk.org/8159
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I98a892016ed61dcf5efeb6619fd748925103f0be
Gerrit-Change-Number: 8159
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 05 Feb 2018 17:57:56 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180205/69286191/attachment.html>


More information about the asterisk-code-review mailing list