[Asterisk-code-review] res pjsip: Implement additional SIP RFCs for Google Voice tr... (asterisk[master])

[Michael L. Young]

Michael L. Young has posted comments on this change. ( https://gerrit.asterisk.org/9505 )

Change subject: res_pjsip: Implement additional SIP RFCs for Google Voice trunk compatability
......................................................................


Patch Set 9:

(6 comments)

https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip/config_transport.c
File res/res_pjsip/config_transport.c:

https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip/config_transport.c@309
PS9, Line 309: 	/* We only currently care about requests that are of the INVITE or CANCEL type but in the
Looks like the comments were missed when fixing the mis-merge that had removed OPTIONS by mistake.


https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip_outbound_registration.c
File res/res_pjsip_outbound_registration.c:

https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip_outbound_registration.c@1415
PS9, Line 1415: static int fetch_access_token(struct ast_sip_auth *auth)
Would it make sense to change the function name to something like "fetch_google_access_token"?


https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip_outbound_registration.c@1435
PS9, Line 1435: 		ast_log(LOG_ERROR, "An error occurred while retreiving OAuth 2.0 access token\n");
s/retreiving/retrieving

s/OAuth 2.0/Google OAuth 2.0


https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip_outbound_registration.c@1457
PS9, Line 1457:  * \brief Set pjsip registration context with any authentication credientials that need to be
s/credientials/credentials


https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip_outbound_registration.c@1461
PS9, Line 1461:  * \param auth_vector The vector of configured authentication credientials
s/credientials/credentials


https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip_outbound_registration.c@1484
PS9, Line 1484: 			ast_debug(2, "Obtaining OAuth access token\n");
s/OAuth/Google OAuth



-- 
To view, visit https://gerrit.asterisk.org/9505
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id214c2d1c550a41fcf564b7df8f3da7be565bd58
Gerrit-Change-Number: 9505
Gerrit-PatchSet: 9
Gerrit-Owner: Nick French <naf at ou.edu>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Michael L. Young <elgueromexicano at gmail.com>
Gerrit-Reviewer: Nick French <naf at ou.edu>
Gerrit-Comment-Date: Thu, 30 Aug 2018 21:20:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180830/cd501c6c/attachment-0001.html>