[Asterisk-code-review] res pjsip: Implement additional SIP RFCs for Google Voice tr... (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/9505 )

Change subject: res_pjsip: Implement additional SIP RFCs for Google Voice trunk compatability
......................................................................


Patch Set 9: Code-Review-1

(5 comments)

preliminary review only

https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip.c
File res/res_pjsip.c:

https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip.c@3294
PS9, Line 3294: 	if (selector == &sel) {
Add some docs to explain that it's the caller's responsibility to free the transport placed in the selector.  We do it only to the internal one we use here.


https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip/config_transport.c
File res/res_pjsip/config_transport.c:

https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip/config_transport.c@206
PS9, Line 206: int ast_sip_transport_set_transport(const char *transport_name, pjsip_transport *transport)
ast_sip_transport_state_set_transport maybe?


https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip/config_transport.c@242
PS9, Line 242: int ast_sip_transport_set_preferred_identity(const char *transport_name, const char *identity)
transport_state


https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip/config_transport.c@270
PS9, Line 270: int ast_sip_transport_set_service_routes(const char *transport_name, struct ast_sip_service_route_vector *service_routes)
same


https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip/config_transport.c@301
PS9, Line 301: void ast_sip_transport_apply_message(const char *transport_name, pjsip_tx_data *tdata)
ast_sip_message_apply_transport maybe?



-- 
To view, visit https://gerrit.asterisk.org/9505
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id214c2d1c550a41fcf564b7df8f3da7be565bd58
Gerrit-Change-Number: 9505
Gerrit-PatchSet: 9
Gerrit-Owner: Nick French <naf at ou.edu>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Michael L. Young <elgueromexicano at gmail.com>
Gerrit-Reviewer: Nick French <naf at ou.edu>
Gerrit-Comment-Date: Thu, 30 Aug 2018 19:01:10 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180830/f931a71c/attachment.html>