<p><a href="https://gerrit.asterisk.org/9505">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip/config_transport.c">File res/res_pjsip/config_transport.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip/config_transport.c@309">Patch Set #9, Line 309:</a> <code style="font-family:monospace,monospace">  /* We only currently care about requests that are of the INVITE or CANCEL type but in the</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Looks like the comments were missed when fixing the mis-merge that had removed OPTIONS by mistake.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip_outbound_registration.c">File res/res_pjsip_outbound_registration.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip_outbound_registration.c@1415">Patch Set #9, Line 1415:</a> <code style="font-family:monospace,monospace">static int fetch_access_token(struct ast_sip_auth *auth)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Would it make sense to change the function name to something like "fetch_google_access_token"?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip_outbound_registration.c@1435">Patch Set #9, Line 1435:</a> <code style="font-family:monospace,monospace">         ast_log(LOG_ERROR, "An error occurred while retreiving OAuth 2.0 access token\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/retreiving/retrieving</p><p style="white-space: pre-wrap; word-wrap: break-word;">s/OAuth 2.0/Google OAuth 2.0</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip_outbound_registration.c@1457">Patch Set #9, Line 1457:</a> <code style="font-family:monospace,monospace"> * \brief Set pjsip registration context with any authentication credientials that need to be</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/credientials/credentials</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip_outbound_registration.c@1461">Patch Set #9, Line 1461:</a> <code style="font-family:monospace,monospace"> * \param auth_vector The vector of configured authentication credientials</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/credientials/credentials</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip_outbound_registration.c@1484">Patch Set #9, Line 1484:</a> <code style="font-family:monospace,monospace">                    ast_debug(2, "Obtaining OAuth access token\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/OAuth/Google OAuth</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/9505">change 9505</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9505"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id214c2d1c550a41fcf564b7df8f3da7be565bd58 </div>
<div style="display:none"> Gerrit-Change-Number: 9505 </div>
<div style="display:none"> Gerrit-PatchSet: 9 </div>
<div style="display:none"> Gerrit-Owner: Nick French <naf@ou.edu> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Michael L. Young <elgueromexicano@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nick French <naf@ou.edu> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 30 Aug 2018 21:20:12 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>