<p style="white-space: pre-wrap; word-wrap: break-word;">preliminary review only</p><p>Patch set 9:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/9505">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip.c">File res/res_pjsip.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip.c@3294">Patch Set #9, Line 3294:</a> <code style="font-family:monospace,monospace">       if (selector == &sel) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Add some docs to explain that it's the caller's responsibility to free the transport placed in the selector.  We do it only to the internal one we use here.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip/config_transport.c">File res/res_pjsip/config_transport.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip/config_transport.c@206">Patch Set #9, Line 206:</a> <code style="font-family:monospace,monospace">int ast_sip_transport_set_transport(const char *transport_name, pjsip_transport *transport)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">ast_sip_transport_state_set_transport maybe?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip/config_transport.c@242">Patch Set #9, Line 242:</a> <code style="font-family:monospace,monospace">int ast_sip_transport_set_preferred_identity(const char *transport_name, const char *identity)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">transport_state</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip/config_transport.c@270">Patch Set #9, Line 270:</a> <code style="font-family:monospace,monospace">int ast_sip_transport_set_service_routes(const char *transport_name, struct ast_sip_service_route_vector *service_routes)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">same</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9505/9/res/res_pjsip/config_transport.c@301">Patch Set #9, Line 301:</a> <code style="font-family:monospace,monospace">void ast_sip_transport_apply_message(const char *transport_name, pjsip_tx_data *tdata)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">ast_sip_message_apply_transport maybe?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/9505">change 9505</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9505"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id214c2d1c550a41fcf564b7df8f3da7be565bd58 </div>
<div style="display:none"> Gerrit-Change-Number: 9505 </div>
<div style="display:none"> Gerrit-PatchSet: 9 </div>
<div style="display:none"> Gerrit-Owner: Nick French <naf@ou.edu> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Michael L. Young <elgueromexicano@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nick French <naf@ou.edu> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 30 Aug 2018 19:01:10 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>