[Asterisk-code-review] app record: Don't set RECORD STATUS chan var until file is ... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7228 )

Change subject: app_record:  Don't set RECORD_STATUS chan var until file is closed
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/7228/1/apps/app_record.c
File apps/app_record.c:

https://gerrit.asterisk.org/#/c/7228/1/apps/app_record.c@171
PS1, Line 171:  * \retval 0 do not exit
             :  * \retval -1 do exit
The return values need to be updated.


https://gerrit.asterisk.org/#/c/7228/1/apps/app_record.c@466
PS1, Line 466: 			switch(rc)
             : 			{
curly location


https://gerrit.asterisk.org/#/c/7228/1/apps/app_record.c@531
PS1, Line 531: 	pbx_builtin_setvar_helper(chan, "RECORD_STATUS", status_response);
status_response may be used uninitialized

Maybe initialize status_response to NULL and not set RECORD_STATUS if NULL?

Probably best if it is initialized to "ERROR".  That seems to be the unhandled exits from the while loop.



-- 
To view, visit https://gerrit.asterisk.org/7228
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fe9de99953e46b4bafa2b38cf151fe8f6488254
Gerrit-Change-Number: 7228
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 15 Nov 2017 19:23:24 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171115/79b98b0a/attachment.html>