[Asterisk-code-review] app record: Don't set RECORD STATUS chan var until file is ... (asterisk[13])

George Joseph asteriskteam at digium.com
Wed Nov 15 14:02:52 CST 2017


Hello Richard Mudgett, Jenkins2, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/7228

to look at the new patch set (#2).

Change subject: app_record:  Don't set RECORD_STATUS chan var until file is closed
......................................................................

app_record:  Don't set RECORD_STATUS chan var until file is closed

We've been calling pbx_builtin_setvar_helper to set the
RECORD_STATUS variable before actually closing the recorded file.
If a client is watching VarSet events and tries to do something with
the file when a RECORD_STATUS event is seen, they might attempt to
do so while the file it's still open.

We now delay calling pbx_builtin_setvar_helper until after we close
the file.

ASTERISK-27423

Change-Id: I7fe9de99953e46b4bafa2b38cf151fe8f6488254
---
M apps/app_record.c
1 file changed, 39 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/28/7228/2
-- 
To view, visit https://gerrit.asterisk.org/7228
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7fe9de99953e46b4bafa2b38cf151fe8f6488254
Gerrit-Change-Number: 7228
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171115/6377d18f/attachment.html>


More information about the asterisk-code-review mailing list