<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7228">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7228/1/apps/app_record.c">File apps/app_record.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7228/1/apps/app_record.c@171">Patch Set #1, Line 171:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> * \retval 0 do not exit<br> * \retval -1 do exit<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The return values need to be updated.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7228/1/apps/app_record.c@466">Patch Set #1, Line 466:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                 switch(rc)<br>                    {<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">curly location</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7228/1/apps/app_record.c@531">Patch Set #1, Line 531:</a> <code style="font-family:monospace,monospace">        pbx_builtin_setvar_helper(chan, "RECORD_STATUS", status_response);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">status_response may be used uninitialized</p><p style="white-space: pre-wrap; word-wrap: break-word;">Maybe initialize status_response to NULL and not set RECORD_STATUS if NULL?</p><p style="white-space: pre-wrap; word-wrap: break-word;">Probably best if it is initialized to "ERROR".  That seems to be the unhandled exits from the while loop.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7228">change 7228</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7228"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I7fe9de99953e46b4bafa2b38cf151fe8f6488254 </div>
<div style="display:none"> Gerrit-Change-Number: 7228 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 15 Nov 2017 19:23:24 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>