[Asterisk-code-review] chan pjsip: Add support for multiple streams of the same type. (asterisk[master])

[Matthew Fredrickson]

Matthew Fredrickson has posted comments on this change. ( https://gerrit.asterisk.org/5876 )

Change subject: chan_pjsip: Add support for multiple streams of the same type.
......................................................................


Patch Set 12:

(3 comments)

Some more feedback...

https://gerrit.asterisk.org/#/c/5876/12/channels/pjsip/dialplan_functions.c
File channels/pjsip/dialplan_functions.c:

https://gerrit.asterisk.org/#/c/5876/12/channels/pjsip/dialplan_functions.c@972
PS12, Line 972: 	if (!state->media_state->topology) {
Are these early returns going to leak state->media_state and potentially other pieces of allocated memory?


https://gerrit.asterisk.org/#/c/5876/12/res/res_pjsip_sdp_rtp.c
File res/res_pjsip_sdp_rtp.c:

https://gerrit.asterisk.org/#/c/5876/12/res/res_pjsip_sdp_rtp.c@1365
PS12, Line 1365: 		return &ast_null_frame;
When is this code needed?  (potentially get a false read callback?)


https://gerrit.asterisk.org/#/c/5876/12/res/res_pjsip_sdp_rtp.c@1391
PS12, Line 1391: 	ast_rtp_instance_set_last_rx(session_media->rtp, time(NULL));
Is this supposed to be updated for rtcp as well?



-- 
To view, visit https://gerrit.asterisk.org/5876
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8afd8dd2eb538806a39b887af0abd046266e14c7
Gerrit-Change-Number: 5876
Gerrit-PatchSet: 12
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 23 Jun 2017 21:12:00 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170623/d559980b/attachment.html>