<p>Matthew Fredrickson <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/5876">View Change</a></p><p>Patch set 12:</p><p style="white-space: pre-wrap; word-wrap: break-word;">Some more feedback...</p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/5876/12/channels/pjsip/dialplan_functions.c">File channels/pjsip/dialplan_functions.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5876/12/channels/pjsip/dialplan_functions.c@972">Patch Set #12, Line 972:</a> <code style="font-family:monospace,monospace">     if (!state->media_state->topology) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Are these early returns going to leak state->media_state and potentially other pieces of allocated memory?</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/5876/12/res/res_pjsip_sdp_rtp.c">File res/res_pjsip_sdp_rtp.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5876/12/res/res_pjsip_sdp_rtp.c@1365">Patch Set #12, Line 1365:</a> <code style="font-family:monospace,monospace">            return &ast_null_frame;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">When is this code needed?  (potentially get a false read callback?)</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5876/12/res/res_pjsip_sdp_rtp.c@1391">Patch Set #12, Line 1391:</a> <code style="font-family:monospace,monospace">   ast_rtp_instance_set_last_rx(session_media->rtp, time(NULL));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Is this supposed to be updated for rtcp as well?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/5876">change 5876</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/5876"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I8afd8dd2eb538806a39b887af0abd046266e14c7 </div>
<div style="display:none"> Gerrit-Change-Number: 5876 </div>
<div style="display:none"> Gerrit-PatchSet: 12 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Mark Michelson <mmichelson@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Matthew Fredrickson <creslin@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 23 Jun 2017 21:12:00 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>