[Asterisk-code-review] chan pjsip: Add support for multiple streams of the same type. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5876 )

Change subject: chan_pjsip: Add support for multiple streams of the same type.
......................................................................


Patch Set 12:

(2 comments)

https://gerrit.asterisk.org/#/c/5876/12/res/res_pjsip_sdp_rtp.c
File res/res_pjsip_sdp_rtp.c:

https://gerrit.asterisk.org/#/c/5876/12/res/res_pjsip_sdp_rtp.c@1365
PS12, Line 1365: 		return &ast_null_frame;
> When is this code needed?  (potentially get a false read callback?)
Yes, it's "tolerate a bad situation" protection.


https://gerrit.asterisk.org/#/c/5876/12/res/res_pjsip_sdp_rtp.c@1391
PS12, Line 1391: 	ast_rtp_instance_set_last_rx(session_media->rtp, time(NULL));
> Is this supposed to be updated for rtcp as well?
Yes, it mirrors the current behavior where we update it for both RTP and RTCP. As long as we're getting any traffic from the other side we're happy.



-- 
To view, visit https://gerrit.asterisk.org/5876
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8afd8dd2eb538806a39b887af0abd046266e14c7
Gerrit-Change-Number: 5876
Gerrit-PatchSet: 12
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 23 Jun 2017 21:17:06 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170623/5074c932/attachment.html>